Notification appearance - Cell padding, center icon, and allow transparent background to the icon

huydq92 / notifications-widget

Automatically exported from code.google.com/p/notifications-widget

0 stars 0 forks source link

Notification appearance - Cell padding, center icon, and allow transparent background to the icon #210

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Issue 120 was about spacing between notifications. 

I think though that cell padding inside the cells would make the normal 
notification view a lot nicer. As it stands the text is very close to the cell 
borders.

Original issue reported on code.google.com by kram...@gmail.com on 16 May 2013 at 4:41

GoogleCodeExporter commented 9 years ago

Did you try v1.0.6? it has a small cell padding between notifications.

Original comment by ad...@roymam.com on 16 May 2013 at 6:17

Changed state: Open

GoogleCodeExporter commented 9 years ago

or perhaps I didn't understand your feature request.
can you post a screenshot of demonstration?

Original comment by ad...@roymam.com on 16 May 2013 at 6:18

GoogleCodeExporter commented 9 years ago

I've got 1.0.6. I think you're talking about cell spacing which is the space 
between the cells which is fine.

I'm talking about cell padding, which is the space between the text in the 
cell, and the edge/border of the cell it is in.

Original comment by kram...@gmail.com on 16 May 2013 at 6:39

GoogleCodeExporter commented 9 years ago

The space between the text in the cell is the standard space when using android 
default appearance presets for text. I'm not going to change that.
so is the space with the edge/borders.
I really don't understand why does it bother anyone, it's readable and 
convince. all of the android applications using same cell spacing for text.
perhaps your specific device settings make it look bad. can you post a 
screenshot so I'll see if it looks like I think it should look?

Original comment by ad...@roymam.com on 16 May 2013 at 7:09

GoogleCodeExporter commented 9 years ago

I've attached a pic from both iOS and from NILS. Notice how the cell padding is 
greater in iOS (eg the bottom edge of the text isn't very close to the border 
as it is in NILS) which gives the effect of better spaced out content.

It's no big deal, the widget is perfectly readable as it is and I'm sure you've 
got other important issues to work on. But just a cosmetic suggestion.

Original comment by kram...@gmail.com on 23 May 2013 at 3:30

Attachments:

GoogleCodeExporter commented 9 years ago

I'll accept this. the iOS notifications does look better.
I'll do the following stuff:
1. Add 2 pixels padding after the text.
2. Center the icon vertically.
3. Allow transparent background to the icon.

Original comment by ad...@roymam.com on 23 May 2013 at 5:45

Changed title: Notification appearance - Cell padding, center icon, and allow transparent background to the icon
Added labels: Milestone-1.0

GoogleCodeExporter commented 9 years ago

1. added very minor padding after the text (2dp ~ 1 pixel). it looks better. I 
didn't want to add more because than the text area will be taller than the 
notification icon.
2. I changed my mind - it's ugly in the middle. kept it top.
3. Fixed on v1.0.8.

Original comment by ad...@roymam.com on 1 Jun 2013 at 2:17

Changed state: Solved