search

huyha85 / opengraph_parser

Simple Ruby Parser library for parsing OpenGraph protocol (http://ogp.me)
MIT License
59 stars 28 forks source link

Remove rescue clause #22

Closed stefansundin closed 9 months ago

stefansundin commented 2 years ago

Let the errors flow! :)

huyha85 commented 2 years ago

Yes I agree that swallowing the error here is very bad. Thank mate.

https://github.com/huyha85/opengraph_parser/pull/20#issuecomment-999924796

stefansundin commented 10 months ago

@huyha85 Hello. I'm cleaning up my stale PRs, so I'll close this PR soon if there is no desire to merge it. Thanks!