search

huyha85 / opengraph_parser

Simple Ruby Parser library for parsing OpenGraph protocol (http://ogp.me)
MIT License
59 stars 28 forks source link

2d828be completely broke http #3

Closed k3rni closed 11 years ago

k3rni commented 11 years ago

Introduced in https://github.com/huyha85/opengraph_parser/commit/2d828bec42c4f434f7fca1278e1b172f656e4713, lib/redirect_follower.rb#28

Unfortunately, get_response doesn't work that way: ruby-doc.org. Passing a second argument (headers hash, empty or not) causes it to use the first one as hostname, which doesn't work.

Minimal example: try RedirectFollower.new('http://google.com').resolve with and without https.

huyha85 commented 11 years ago

Thank you very much. I have committed this in rush, and met a big error. I have upgraded the gem to 0.2.2 to fix this. Sorry for any inconvenience.