huynguyen-and-friend-projects / smoldb

Simple database in C
1 stars 3 forks source link

Remove the SMOL_INTERNAL and SMOL_API macros #30

Closed nguyenhuy0905 closed 6 days ago

nguyenhuy0905 commented 1 month ago

What?

Remove the SMOL_INTERNAL and SMOL_API, and instead simply rely on extern and/or static.

Why?

I don't think we need to be that specific. What we define in the c-api header is automatically an API call, the others, internal.

How?

After we remove SMOL_API and SMOL_INTERNAL, just replace whatever uses that macro with extern

Request by: Huy Nguyen

nguyenhuy0905 commented 6 days ago

Nevermind, I learned what these are for. No need to remove them. But, we will change them from defining "external" and "static" to defining nothing at all.