Submission for assignment 2 - Githubissues

huynhtunhan1995 / df-frontend-2023

HTML CSS simple

https://kevin-df-frontend-2023.vercel.app

0 stars 0 forks source link

Submission for assignment 2 #2

Open huynhtunhan1995 opened 1 year ago

huynhtunhan1995 commented 1 year ago

Demo link : https://kevin-react-df-frontend-2023.vercel.app/
// Any notes for reviewers

chinhld12 commented 1 year ago

Hi @huynhtunhan1995 ,

Requirements

[x] Render book list with pagination
[x] Create book
[x] Delete book
[x] Search book by title
[x] Standard use of React component & state
[ ] Light/dark mode

Final result: ✅ passed

Feedback

Should make a pure function method with wrapping the localStorage operations with an error handler for this code blocks https://github.com/huynhtunhan1995/df-frontend-2023/blob/c280ccbf5221e62ae7d287435cbc83905a05d343/assignment-2/src/components/booksData.js#L10-L11
Could you please enhance the UI styling a bit? It currently appears reminiscent of a website design from the early 2000s.

huynhtunhan1995 commented 1 year ago

Bro, thanks for your feedback. I will upgrade the Light/dark mode in assigment-3 and styling also