search

huynqbibabo / react-native-newrelic

MIT License
8 stars 3 forks source link

Fix iOS imports for new react-native releases #7

Open IjzerenHein opened 2 years ago

IjzerenHein commented 2 years ago

Fixes #6

Hi! There have been build issues with this package using newer react-native versions. This PR fixes the imports to work on all versions of react-native by correctly scoping them.

IjzerenHein commented 2 years ago

@huynqbibabo If you have some time to merge and release this, that would be very helpful. Thanks for maintaining this library 🙏 💜

huynqjmango360 commented 2 years ago

hi @IjzerenHein for some pretty stupid reason, I wasn't able to get my git account back for this package and I had to create a new git 😂😂, you can see it here. it already includes your pr. Thank you so much for your contribution! https://github.com/huynq1175/react-native-newrelic-agent https://www.npmjs.com/package/@abeman/react-native-newrelic-agent

IjzerenHein commented 2 years ago

Awesome, thanks for maintaining this @huynqjmango360 ❤️ I'll migrate to the new NPM package.

Also, I created a couple PR's which apply some fixes to the README 👍 https://github.com/huynq1175/react-native-newrelic-agent/pulls

ChrisLFieldsII commented 2 years ago

hi @IjzerenHein for some pretty stupid reason, I wasn't able to get my git account back for this package and I had to create a new git 😂😂, you can see it here. it already includes your pr. Thank you so much for your contribution! https://github.com/huynq1175/react-native-newrelic-agent https://www.npmjs.com/package/@abeman/react-native-newrelic-agent

Hello :)

Can you please fix the links? They seem to have the wrong url.

Also it will be extremely helpful to archive this repo and mark former npm pkg as deprecated and link others to new repo/npm pkg.

I can help document this to save ppl time if you can not, just let me know.

Thanks!

huynqjmango360 commented 2 years ago

hi @IjzerenHein for some pretty stupid reason, I wasn't able to get my git account back for this package and I had to create a new git 😂😂, you can see it here. it already includes your pr. Thank you so much for your contribution! https://github.com/huynq1175/react-native-newrelic-agent https://www.npmjs.com/package/@abeman/react-native-newrelic-agent

Hello :)

Can you please fix the links? They seem to have the wrong url.

Also it will be extremely helpful to archive this repo and mark former npm pkg as deprecated and link others to new repo/npm pkg.

I can help document this to save ppl time if you can not, just let me know.

Thanks!

Hi @ChrisLFieldsII. I can't access the git or npm of this package anymore so I can't make updates. Here is the link to the new package: https://github.com/huynq1175/react-native-newrelic-agent If you have any modification, please create pr into react-native-newrelic-agent. Many thanks for your contribution!

ChrisLFieldsII commented 2 years ago

hi @IjzerenHein for some pretty stupid reason, I wasn't able to get my git account back for this package and I had to create a new git 😂😂, you can see it here. it already includes your pr. Thank you so much for your contribution! https://github.com/huynq1175/react-native-newrelic-agent https://www.npmjs.com/package/@abeman/react-native-newrelic-agent

Hello :) Can you please fix the links? They seem to have the wrong url. Also it will be extremely helpful to archive this repo and mark former npm pkg as deprecated and link others to new repo/npm pkg. I can help document this to save ppl time if you can not, just let me know. Thanks!

Hi @ChrisLFieldsII. I can't access the git or npm of this package anymore so I can't make updates. Here is the link to the new package: https://github.com/huynq1175/react-native-newrelic-agent If you have any modification, please create pr into react-native-newrelic-agent. Many thanks for your contribution!

My apologies!! @huynqjmango360

I read that but obviously didn't fully process it.

Thanks for the package! It really helps a lot.