search

huysentruitw / SapNwRfc

SAP NetWeaver RFC library for .NET 5, .NET Core and .NET Framework
MIT License
148 stars 43 forks source link

Only create a new array when advertised row count is below actual row… #30

Closed campersau closed 3 years ago

campersau commented 3 years ago

… count

Before a new array was always created if rowCount > 0.

~~The if check isn't necessary before Array.Resize since the length is there checked too https://github.com/dotnet/runtime/blob/8b6f404bd5de08f322e5385458886b64c01ce258/src/libraries/System.Private.CoreLib/src/System/Array.cs#L52~~ I have removed the if check so codecov is happy.

codecov-commenter commented 3 years ago

Codecov Report

Merging #30 (63e69cc) into master (95d1c3d) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   83.74%   83.75%   +0.01%     
==========================================
  Files          32       32              
  Lines         941      942       +1     
  Branches      135      135              
==========================================
+ Hits          788      789       +1     
  Misses        150      150              
  Partials        3        3
Impacted Files Coverage Δ
src/SapNwRfc/Internal/Fields/TableField.cs 97.91% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95d1c3d...63e69cc. Read the comment docs.

t3643797 commented 3 years ago

Thank you very much

huysentruitw commented 3 years ago

Thanks, great work 💪