Open Cxarli opened 7 years ago
@C-Bouthoorn could you please check the conflict here please?
@C-Bouthoorn would it make sense to have three separate commits (or even three PRs) for three bullet points mentioned accordingly in the PR description? IMHO, that makes PR reviewing easier and commit tree traversal in the future better.
Yeah, could be. I just scanned through the code and applied changes everywhere, then made a commit and wrote the description afterwards. I didn't really think I would do multiple things
The code in the
/www
folder is now a bit cleaner, by:The colors from
theme.scss
are now incolors.scss
, so that they can be changed easily later.I recommend using tools such as
eslint
,jshint
andsass-lint
to keep your code clean. This commit also adds configuration files for them.Happy hacktober!