search

hvac / hvac

:lock: Python 3.X client for HashiCorp Vault
https://python-hvac.org
Apache License 2.0
1.2k stars 377 forks source link

Publish PEP 561 types #800

Open candrews opened 2 years ago

candrews commented 2 years ago

It would be really nice if hvac could publish PEP 561 type information allowing users of hvac to use mypy to type check their code.

Thank you!

kasium commented 1 year ago

Any opinions on this alredy. Is this something which can be considered? Or should they be added to typeshed?

JakeSummers commented 1 year ago

Any opinions on this alredy. Is this something which can be considered? Or should they be added to typeshed?

I strongly prefer when they are bundled with the library. That is an easier dev experience and they are more resilient to break changes across major versions.

kasium commented 4 months ago

Since there seems no progress on this issue since a while and publishing them as part of typeshed is easier, I created a PR: https://github.com/python/typeshed/pull/11591

Ry-DS commented 4 months ago

@kasium you sir are a legend. Thank you! Can't wait to use them once your PR is merged