search

hvanbakel / CsprojToVs2017

Tooling for converting pre 2017 project to the new Visual Studio 2017 format.
MIT License
1.08k stars 120 forks source link

VB support #211

Closed baruchiro closed 5 years ago

baruchiro commented 5 years ago

The AssemblyInfo.vb located in "My Project" subfolder.

hvanbakel commented 5 years ago

We make assumptions about where to find assembly info files, there’s no other way really. The only other way is to parse and/or compile the entire project which is not something we want to do as part of conversion. There’s not that many cases where people actually move that file, and nothing breaks if we don’t find one (as far as I know). So while suboptimal, I don’t see a way of solving this.

baruchiro commented 5 years ago

I think that I do not understand. If we make assumptions, why "My Project" it is not one of our assumptions? If you open VS and create new VB Console Application project, you will find the AssemblyInfo.vb in "My Project" folder.

hvanbakel commented 5 years ago

😄 well the project name is csprojtovs2017 so the emphasis was clearly on csproj files as that’s the only language that I personally work with.

Previously there have been requests for vb support which is there now (kind of). But things like this where it is different from C# are the areas that weren’t addressed.

The issue is in CsprojToVs2017/Project2015To2017.Core/Reading/AssemblyInfoReader.cs Which apparently was never made vb aware.