search

hvanbakel / CsprojToVs2017

Tooling for converting pre 2017 project to the new Visual Studio 2017 format.
MIT License
1.08k stars 120 forks source link

GeneratePathProperty got lost during conversion #278

Open rednaxLamington opened 4 years ago

rednaxLamington commented 4 years ago

In the old csproj format file a package was included using: `

2.38.0.2 
</PackageReference>`

In the new format this is formatted as : <PackageReference Include="Graphviz" Version="2.38.0.2"/> It should be: <PackageReference Include="Graphviz" Version="2.38.0.2" GeneratePathProperty="true"/>

The GeneratePathProperty is needed to included package items to the project (for example): `

GraphViz\zlib1.dll 
  <CopyToOutputDirectory>Always</CopyToOutputDirectory>
</Content>`
mungojam commented 4 years ago

Are you sure that it is still needed? I think I have seen those properties get defined automatically in the auto-generated files in the obj folder when using the new project format.

I've also consumed them too

rednaxLamington commented 4 years ago

That is a really good question. I can only answer that by trying.

But either way, the GeneratePathProperty is supported in both formats, so it seems logical to me to convert that attribute too. Right now my projects are failing because of this.