search

hvanbakel / CsprojToVs2017

Tooling for converting pre 2017 project to the new Visual Studio 2017 format.
MIT License
1.08k stars 120 forks source link

VB.NET projects transformation is not supported to .NET 5 #289

Open cChevez opened 3 years ago

cChevez commented 3 years ago

Hi, I'm trying to migrate a VB.NET project to .NET5, but there's a line that is not removed, i.e,

... Import Project="$(MSBuildToolsPath)\Microsoft.VisualBasic.targets" ...

I was reviewing your code and the problems seems to be related with the following code:

private static readonly string[] RemoveMSBuildImports = { @"$(MSBuildToolsPath)\Microsoft.CSharp.targets", @"$(MSBuildBinPath)\Microsoft.CSharp.targets", @"$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props", };

Could you please add the same elements but for VB.NET.

private static readonly string[] RemoveMSBuildImports = { @"$(MSBuildToolsPath)\Microsoft.VisualBasic.targets", @"$(MSBuildBinPath)\Microsoft.VisualBasic.targets", @"$(MSBuildToolsPath)\Microsoft.CSharp.targets", @"$(MSBuildBinPath)\Microsoft.CSharp.targets", @"$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props", };

Regards.