hvdwolf / jExifToolGUI

jExifToolGUI is a multi-platform java/Swing graphical frontend for the excellent command-line ExifTool application by Phil Harvey
https://hvdwolf.github.io/jExifToolGUI/
GNU General Public License v3.0
461 stars 38 forks source link

Changes to GPS tab #167

Closed Sponsoredby closed 2 years ago

Sponsoredby commented 3 years ago

is it possible for an additional features?

when clicking find location, it uses the long and lat coordinates from the image, which you get when selecting (copy from selecting images ) rather than having to type a place name in, which you might not know.

Also is it possible to decide what data is pulled from the nomanatim lookup

hvdwolf commented 3 years ago

Hi, Useful features are always possible 😉 (unless I can't build it)

I do not exactly know what you mean with your first remark. It does NOT copy the coordinates from the image which you used for the "copy from selected image". For the very first load after very first program start, it uses the coordinates from the city where I live. On every subsequent "Find Location", it uses the location coordinates from the last search, which are autosaved to the preferences. Not from that "copy from selected image" image.

Or do you mean that you want to use the coordinates from that "copy from selected image" to find the corresponding location, region, city, etcetera? (if applicable of course)

I don't understand what you mean with which data is pulled from nominatiom lookup. Please give an example.

Sponsoredby commented 3 years ago

Thanks for the speedy reply,

Yes i mean this

Or do you mean that you want to use the coordinates from that "copy from selected image" to find the corresponding location, region, city, etcetera? (if applicable of course) - the reason been some relatives have taken photos abroad but can not remember exactly where they were taken, so a find location on the photos coordinates would quickly do that.

secondly some examples of nominatim data lookup, I find relevant on some of my images are county, town, country_code, state_district, suburb I would ultimately like to get this into the keywords, which i have worked out can be done with

exiftool -addtagsfromfile @ '-keywords<country' '-keywords<Location' imagename.jpg etc etc

hvdwolf commented 3 years ago

The coordinates will work but will not be iimplemented in the coming release (before next weekend hopefully). It requires a reverse nominatim lookup (or was name search reverse? Can't remember now). This requires some more active programming.

With regard to your second request: I will have a look at it.

hvdwolf commented 3 years ago

I quickly checked my code and searching on coordinates already works, be it manually. If you use the "copy from selected", and then manually copy the coordinates into the "Find Location" window, you can search on it. I will create a button for it to automate it.

Yosemite national park, California Screenshot 2021-10-18 19 29 41

Sagrada Familia, Barcelona Screenshot 2021-10-18 19 35 51

hvdwolf commented 3 years ago

secondly some examples of nominatim data lookup, I find relevant on some of my images are county, town, country_code, state_district, suburb I would ultimately like to get this into the keywords, which i have worked out can be done with

exiftool -addtagsfromfile @ '-keywords<country' '-keywords<Location' imagename.jpg etc etc

First of all: which keywords? iptc (default exiftool) or xmp? If I used the standard iptc ones, you get for Sacramento in California for country, location something like "United States, Sacramento, Sacramento County, California, United States" and for the "Eiffel tower" in Paris, you get "France, Tour Eiffel, 5, Avenue Anatole France, Quartier du Gros-Caillou, Paris 7e Arrondissement, Paris, Île-de-France, France métropolitaine, 75007, France"

And for "county, town, country_code, state_district, suburb" you get only incomplete data as country_code might be delivered, but state_district and suburb not. For those you get at best the "Admin level" for a city you searched for which doesn't normally mean anything and differ per country. And if you search on "a thing" like a POI or national park, etc. you get something completely different. And if I search for "Yosemite National Park", I do not even get a city. This will all be way too complicated.

In that case the Edit -> XMP tab for xmp keywords, or the Edit->XMP+IPTC String+ tab, might be better suited for your needs, but it will not be automatic.

Edit: The search by coordinates works. When I build a beta I will inform you in this thread.

https://user-images.githubusercontent.com/4520361/138599663-38e545bc-e28a-422e-b758-3ccd41689aa0.mp4

hvdwolf commented 2 years ago

What OS are you on and which package do you use?

Sponsoredby commented 2 years ago

Yes I have noticed some inconsiticenses in the data nominatim returns, so I can see the issues it would cause implementing the changes. I am using jexiftoolgui with ubuntu 18.04

hvdwolf commented 2 years ago

Yes, but which package? jar, deb, appimage?

Anyway, I added a 1.9.0.1- beta deb and jar on mega.nz

Sponsoredby commented 2 years ago

.deb thanks I will take a look at it soon