search

hvesalai / emacs-sbt-mode

An emacs mode for interacting with scala sbt and projects
GNU General Public License v3.0
125 stars 38 forks source link

Restore completion behavior in REPL for scala 2.11 and 2.12, will not… #135

Closed hvesalai closed 6 years ago

hvesalai commented 6 years ago

… work for 2.13

This effectively reverts 8da22bf543788001a7d5cd62449a674ced0d2c0c by @markus1189, which made the prompt regexp accept the magic [completions] string as the beginning of a prompt, which -- together with a completion such as > -- broke the completion functionality.

Fixes #133, #125, #117

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

markus1189 commented 6 years ago

Is there no way to also support the [<project>] syntax? Just asking, I'm okay with having this merged, I can ad-hoc fix it for projects that use that special form anyway

hvesalai commented 6 years ago

@markus1189 the regexp for prompt can be anything as long as it doesn't match [completions] >. If it maches that, then compeltions will stop working.