hvesalai / emacs-sbt-mode

An emacs mode for interacting with scala sbt and projects
GNU General Public License v3.0
125 stars 38 forks source link

Reverted bogus fix for JLine #137

Closed hvesalai closed 6 years ago

hvesalai commented 6 years ago

@fommil discuss

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

fommil commented 6 years ago

completions are working for me without this, and if this is merged we lose ansi colours... so I'd quite like to keep it.

If it's impacting you then maybe put it behind a feature flag?

hvesalai commented 6 years ago

I need to draw a complete picture of this. The bottom line is this:

If you have "echo" enabled in JLine, completions will not work reliably untill the :completions command is implemented in scalac.