search

hvesalai / emacs-sbt-mode

An emacs mode for interacting with scala sbt and projects
GNU General Public License v3.0
126 stars 38 forks source link

Add variable for customizing how SBT gets displayed #155

Closed Kazark closed 4 years ago

Kazark commented 4 years ago

I prefer to have SBT show up in a small window at the bottom of my screen. This gives me a hook to make that happen, while not boxing anyone else into that; it is a non-breaking change.

I hope this fits in a way consistent with the existing design. I used a defvar rather than a defcustom, which I saw for a lot of things, because this new variable is unlikely to be useful without writing a bit of ELisp.

More of the rationale for why the change is the way it is, and what else I tried before making it, can be seen in the documentation string for the variable.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

Kazark commented 4 years ago

@hvesalai Thanks for the review. Will address all your comments and give you a heads up when it's ready again.

Kazark commented 4 years ago

@hvesalai I was looking at this more and wondering if I should actually move most of the doc for it, including the example, into the README. However, it wasn't obvious to me what section I should put it in. Thoughts on that?

hvesalai commented 4 years ago

Hmm... the documentation should have things that do not require in-depth emacs knowledge, such as just tuning some configuration parameter. I think this feature requires lisp-knowledge, so it's for the more advanced users.

Kazark commented 4 years ago

@hvesalai Okay, makes sense. I'll just make the changes as you originally suggested then. Thanks.

Kazark commented 4 years ago

@hvesalai Alright, let me know how that looks. I'm quite happy to take a second round of feedback if necessary.