search

hvesalai / emacs-scala-mode

The definitive scala-mode for emacs
http://ensime.org
GNU General Public License v3.0
361 stars 68 forks source link

Implemented prettify/conceal with a base set of rules. #108

Closed mgttlinger closed 8 years ago

mgttlinger commented 8 years ago

What is prettified can be configured by adding or removing from the scala--prettify-symbols-alist.

CLAassistant commented 8 years ago

CLA assistant check
All committers have signed the CLA.

fommil commented 8 years ago

@mgttlinger lots of comments :smile: but I think this looks good and the comments above are easily addressed. Just push commits addressing the above and we'll squash merge when it looks good.

mgttlinger commented 8 years ago

Thanks for the suggestions, I'll implement them when I find time to do so.

fommil commented 8 years ago

I'm looking forward to this, I'm not sure whether I'll love it or hate it. Once merged, please add some docs over at http://ensime.github.io/editors/emacs/scala-mode/ and maybe some suggestions of Libre fonts that are known to work well.

fommil commented 8 years ago

there must be something wrong with my github notifications, I came here to ping you and you've already updated it! :smile:

fommil commented 8 years ago

I'm going to add some CI to this repo today so we can get some level of confidence that the code at least parses.

fommil commented 8 years ago

@mgttlinger great stuff! Can you please update the documentation with instructions on how to enable this feature?

mgttlinger commented 8 years ago

@fommil Cool! I'll update the documentation. About the font recommendation: Can you explain in one sentence what the difference between Libre and OpenSource is?

fommil commented 8 years ago

@mgttlinger oh, the final version still has -- double dash in the variable name. Can you please send a quick update with a fix for that before writing the docs?

fommil commented 8 years ago

I think using setq is the correct recommendation, because it's buffer local.

fommil commented 8 years ago

actually, I'll push a quick fix for the symbol name.

mgttlinger commented 8 years ago

@fommil I'll remove the -- when I have figured out how to sync the changes from this repo to my fork.

fommil commented 8 years ago

@mgttlinger I've already done it :wink:

Instructions should be to add this in a scala-mode-hook

            (setq prettify-symbols-alist scala--prettify-symbols-alist)
            (prettify-symbols-mode)
fommil commented 8 years ago

@mgttlinger https://github.com/ensime/emacs-scala-mode/commit/ee375b9357a71d77763e219dac15850ed60530b3?w=1

mgttlinger commented 8 years ago

Related PR: https://github.com/ensime/ensime.github.io/pull/124