search

hvesalai / emacs-scala-mode

The definitive scala-mode for emacs
http://ensime.org
GNU General Public License v3.0
362 stars 68 forks source link

Remove ob-scala.el since it depends on abandoned ensime #155

Closed tarsius closed 4 years ago

tarsius commented 4 years ago

Because ensime has been abandoned, you probably should remove ob-scala.el.

I ran into this as part of my work on the Emacsmirror. This is one of less than a dozen missing features among the ~5000 thousand mirrored packages.

Thanks for looking into this.

tarsius commented 4 years ago

Friendly ping! :beer:

tarsius commented 4 years ago

Thanks!

kschwarz1116 commented 4 years ago

I'm not entirely sure what would cause this, but it looks like this change did not result in a change in package number on MELPA. This still shows 20190929.1522. As a result, I still had ob-scala.el in my elpa directory. Uninstalling and reinstalling the package seemed to fix it, so I'm just leaving this comment here in case anyone else runs into it.

VitalyAnkh commented 2 years ago

Since you have merged the two ob-scala.el to this package, then removed the ob-scala.el here, how could the users use org babel for scala? Is a new ob-scala.el planned? :(

hvesalai commented 2 years ago

@VitalyAnkh we welcome all PRs. I never used ob-scala my self, so am not the best person to maintain it.