search

hvesalai / emacs-scala-mode

The definitive scala-mode for emacs
http://ensime.org
GNU General Public License v3.0
362 stars 68 forks source link

Revert "compile mode with sbt thin client" #166

Open hvesalai opened 3 years ago

hvesalai commented 3 years ago

@fommil I merged it, but came to other thoughts.

I think your PR should have been in the emacs-sbt-mode project, not here. What do you say?

Reverts hvesalai/emacs-scala-mode#165

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

fommil commented 3 years ago

I'm not sure it belongs in the sbt mode because this compilation mode should be build tool agnostic (I just chose sbt as the default). e.g. a user could swap the command out of maven or gradle or fury or mill or whatever... it's just a bog standard batch compilation mode.