search

hvesalai / emacs-scala-mode

The definitive scala-mode for emacs
http://ensime.org
GNU General Public License v3.0
361 stars 68 forks source link

Couple imenu-related issues #95

Closed ancane closed 8 years ago

ancane commented 9 years ago

Hello, @hvesalai. I ran into couple issues while using imenu feature:

  1. Stack overflows under certain conditions
  2. Nested elements reverse ordering.
  3. False positive matches with definitions regex. Hope this works fine. Thanks.
fommil commented 8 years ago

is this still alive? Now we have popup menu with ensime support, maybe not, but would be good for this base support to work off regex.

@ancane can you please sign the CLA ?

ancane commented 8 years ago

@fommil I guess so as this PR fixes couple annoying things about regex-imenu. It's all in commit messages.

fommil commented 8 years ago

cool, I just had a look through and it sees sensible to me. We can always back out if it breaks everything. It would be great if you wrote some tests around this, is that something you'd have time to look into?