Submitting Week #2 Homework Assignment

[hvfenrir]

Here is my completed prework assignment! Thank you /cc @coderschoolreview

[hoksilato]

Hi @hvfenrir, nice work with great homework. :+1:

The goals of this homework are:

• to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
• to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
• to build more complex forms in views that involve multiple models.

Quick review:

• Excellent with Material Design UI. It's really beautiful.
• Good use with scope on user.rb model.
• Good work with current_user, logged_in? helper method and before_action on messages_controller.rb.

Some small issues:

• Still had Sign Up button at homepage after signed in, and still access sign up page.

Suggestions

• Should validate email presence and its validity on your sign up form.
• Should check whether user signed in or not before allowing them add friends or send message..
• Should validate new message form.

Gemfile:

• I didn't see you include rails_12factor gem for Heroku.

Routes:

• There are duplicate routes: resources :friendships and resources :messages.
• As you see, we only need new, create and destroy routes for sessions so that narrow them with resources :sessions, only: [:index, :new, :destroy].

Congrats again on the submission. Everyone has limited time; it's good to see you finished all required and some of optional functionalities. Thanks for your hard work and please keep your good work :100:. Let us know if you have any feedback.