hvxl / otmonitor

Monitor tool for the OTGW (http://otgw.tclcode.com/)
GNU Lesser General Public License v3.0
27 stars 10 forks source link

Blocking error window keeps poping up #22

Closed richardscholten73 closed 1 year ago

richardscholten73 commented 1 year ago

An anoying error window keeps poping up when i connect to my OTGW. The windows is blocking and i have to close it to be able to control otmonitor. Only to reapear after a few seconds, making it almost imposible to do anything...

The error message:|

can't set "gui(returntemp)": can't use non-numeric string as operand of "-"
can't use non-numeric string as operand of "-"
    while executing
"expr {$gui(boilertemp) - $gui(returntemp)}"
    (procedure "deltatemp" line 4)
    invoked from within
"deltatemp gui returntemp write"
    (write trace on "gui(returntemp)")
    invoked from within
"set gui($name) ???"
    (procedure "unknownid" line 6)
    invoked from within
"unknownid returntemp 0"
    invoked from within
"::specialcoro timer"
    ("after" script)

My boiler does not report the return temperature, and in OTGW it is always displayed as 0.

The error seems to be raised in this line of code: https://github.com/hvxl/otmonitor/blob/9c3f19dbe6f201032d48c5149925f12851bae42e/otmonitor.vfs/otmonitor.tcl#L1342

There are checks in place to see if it is a numeric value, but i have no clue why the error is raised.

hvxl commented 1 year ago

That error was only fixed recently and hasn't made it into a released version of OTmonitor yet. Looking at the error message, it seems you are still using a version that doesn't have the checks.

Binaries for the latest development version of OTmonitor are automatically built via github actions. Please try the binary for your platform from the latest actions workflow run and let me know if that still exhibits the problem.

richardscholten73 commented 1 year ago

Yes, the issue is fixed in the new version.

Thank you for the support.