hwameistor / hwameistor-operator

Operator that manages HwameiStor
Apache License 2.0
8 stars 10 forks source link

DRBDAdapter cannot correctly identify the system version #290

Open san3Xian opened 1 month ago

san3Xian commented 1 month ago

hwameistor operator version: v0.14.4
https://github.com/hwameistor/hwameistor-operator/blob/8d06d4a0cfdabe11d57ae212d0387927d2d7d569/pkg/install/drbd/drbd_adapter.go#L117-L131
https://github.com/hwameistor/hwameistor-operator/blob/8d06d4a0cfdabe11d57ae212d0387927d2d7d569/pkg/install/drbd/drbd_adapter.go#L43-L51

image

The regular expression uses wildcards too broadly, causing issues with version identification.

image

BTW, Why did hwameistor delete all the DRBD installation jobs? This causes significant difficulties for troubleshooting and identification.

SSmallMonster commented 1 month ago

Why did hwameistor delete all the DRBD installation jobs? This causes significant difficulties for troubleshooting and identification.

You are right. From my opinion, jobs that are stopped with failure should be reserved until user delete them manually for other purposes e.g. reinstall. Is there any logs shown that jobs were deleted by hwameistor-operator and how to reproduce it.

cc @peng9808

san3Xian commented 1 month ago

Moreover, I cannot simply re-trigger the DRBD driver installation by editing the cluster resource, and the failed jobs was disapper😭

SSmallMonster commented 1 month ago

As the error for incorrectly indentify OS version, maybe we should use more strict regex to distinguish Major, Minor version from /etc/os-release.

SSmallMonster commented 1 month ago

Moreover, I cannot simply re-trigger the DRBD driver installation by editing the cluster resource, and the failed jobs was disapper😭此外,我不能简单地通过编辑集群资源来重新触发 DRBD 驱动程序安装,并且失败的作业是 disapper😭

This has been one of our planned improvement.

peng9808 commented 1 month ago

I will try to fix it in August