search

hwayne / learntla-v2

Learn TLA+ for free! No prior experience necessary!
https://www.learntla.com
Other
183 stars 39 forks source link

feature request: all images should be clickable #67

Open acud opened 11 months ago

acud commented 11 months ago

Something that I noticed while reading this is that the often attached images aren't clickable. It would be nice to have them all clickable, ideally opening in a new tab. As of right now the flow to actually viewing them is right-clicking and then opening the image in a new tab/window. It's a bit clunky however necessary more often than not. Especially since most of the screenshots aren't properly cropped and in their natural state (for laptop users) they aren't legible.

I'm happy to go through the docs and do the change if it's OK.

hwayne commented 11 months ago

That makes sense. I was gonna get to learntla work again next week, can do it then if you're willing to wait. Otherwise a pr is fine!

On Sun, Jul 23, 2023, 1:42 AM acud @.***> wrote:

Something that I noticed while reading this is that the often attached images aren't clickable. It would be nice to have them all clickable, ideally opening in a new tab. As of right now the flow to actually viewing them is right-clicking and then opening the image in a new tab/window. It's a bit clunky however necessary more often than not. Especially since most of the screenshots aren't properly cropped and in their natural state (for laptop users) they aren't legible.

I'm happy to go through the docs and do the change if it's OK.

— Reply to this email directly, view it on GitHub https://github.com/hwayne/learntla-v2/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUJO5ETADMVA7QIAMFJ4XDXRTBWXANCNFSM6AAAAAA2UKE67U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hwayne commented 11 months ago

I did a quick test in the new optimizations work and making them clickable is just a matter of adding a :target: field, though annoyingly enough you have to point it at the generated _images folder, not the original path.

hwayne commented 11 months ago

BTW, thanks for all of your comments and PRs =)

hwayne commented 10 months ago

Hi @acud, can you confirm this image does what you expect it to? https://www.learntla.com/topics/optimization.html#use-the-profiler

acud commented 10 months ago

Yes it does, however ideally it should open in a new tab (though I'm not positive that RST can do that... in which case this will suffice)

BTW, thanks for all of your comments and PRs =)

My pleasure!