search

hwchase17 / notion-qa

MIT License
2.13k stars 374 forks source link

adding arg for supplying a custom ingestion directory #3

Closed barnjamin closed 1 year ago

barnjamin commented 1 year ago

In the README the user is instructed to unzip a directory inside this repo and ingest.py is hardcoded to that path.

Instead consider allowing a cli flag to point to another directory outside this repos root so it can ingest from an existing local directory containing markdown files.

If this is wanted a tweak to the README would also be needed

Note: I've only verified this generates a set of paths to ingest, I've not yet tested that this method works for arbitrary markdown as opposed to some Notion specific format

barnjamin commented 1 year ago

Forgot I had this outstanding and pushed some extra changes that are unrelated, the first commit has the changes for adding cli flag, if you want it I can resubmit another pr or feel free to yoink it