hwchen / keyring-rs

Cross-platform library and utility to manage passwords
Apache License 2.0
450 stars 49 forks source link

update to zbus v4 #166

Open thewh1teagle opened 4 months ago

thewh1teagle commented 4 months ago

I use dialog plugin from tauri which uses zbus v4, And I can't use this library along with that plugin because there's a conflict.

Do you have plans to update it to zbus v4? secret-service/Cargo.toml#L37

Error:

error: failed to select a version for `zvariant_utils`.
    ... required by package `zbus_macros v4.0.0`
    ... which satisfies dependency `zbus_macros = "=4.0.0"` of package `zbus v4.0.0`
    ... which satisfies dependency `zbus = "^4.0"` of package `ashpd v0.8.0`
    ... which satisfies dependency `ashpd = "^0.8"` of package `rfd v0.14.0`
    ... which satisfies dependency `rfd = "^0.14"` of package `tauri-plugin-dialog v2.0.0-beta.1 (https://github.com/thewh1teagle/plugins-workspace?branch=v2#dc6d3321)`
    ... which satisfies git dependency `tauri-plugin-dialog` of package `app_name v0.2.8 (/Users/user/Documents/app_name/app_name/src-tauri)`
versions that meet the requirements `=1.1.0` are: 1.1.0

all possible versions conflict with previously selected packages.

  previously selected package `zvariant_utils v1.0.1`
    ... which satisfies dependency `zvariant_utils = "=1.0.1"` (locked to 1.0.1) of package `zbus_macros v3.15.2`
    ... which satisfies dependency `zbus_macros = "=3.15.2"` (locked to 3.15.2) of package `zbus v3.15.2`
    ... which satisfies dependency `zbus = "^3.7"` (locked to 3.15.2) of package `secret-service v3.0.1`
    ... which satisfies dependency `secret-service = "^3"` (locked to 3.0.1) of package `keyring v2.3.2`
    ... which satisfies dependency `keyring = "^2.2.0"` (locked to 2.3.2) of package `app_name` v0.2.8 (/Users/user/Documents/app_name/app_name/src-tauri)`
brotskydotcom commented 4 months ago

Sorry, but I'm not a secret-service maintainer, so I can't help you with this. I see you've also filed a bug with secret-service about this; hopefully they will get to it fairly soon and then I will take their update here.

brotskydotcom commented 1 week ago

The tracking bug is hwchen/secret-service-rs#71, which was closed before the release was made. Hoping to see a release soon.

brotskydotcom commented 1 week ago

The secret-service release has been made, and I'll get it integrated in the next week or two. I'm leaning towards making this a minor release, since the API for this crate is not changing, but I'm open to thoughts from others. It's such a big dependency change it might be worth a major release just to warn people.