search

hwchen / secret-service-rs

Rust library for interfacing with Secret Service API
Apache License 2.0
72 stars 28 forks source link

Update aes to 0.8, replace deprecated block-modes with cbc #59

Closed nc7s closed 10 months ago

complexspaces commented 1 year ago

Thanks for this. Would you mind rebasing these changes on master in a day or two once I merge #58 this week? It also touches the same code area so there will be conflicts.

nc7s commented 1 year ago

Sure, just tag me when it's merged.

complexspaces commented 1 year ago

@bnoctis I've merged that PR, and some CI fixes, into master earlier today so you should be able to rebase now. I'll be happy to start review after that (even though at a glance, it seems like everything is fine).

nc7s commented 1 year ago

@complexspaces done, please approve the actions run so we can see if it passes tests; I have to add --features=rt-async-io-crypto-rust to let it compile locally before tests start to run.

nc7s commented 1 year ago

Any news? 😃

nc7s commented 10 months ago

Closing for now. Ping me if still interested.

complexspaces commented 6 months ago

@nc7s Hi again, I apologize for going quiet here. This repository is usually the first to fall off when I get busy.

Are you still interested in merging this? I should have the bandwidth to help you get this one landed and released on crates.io.

complexspaces commented 3 months ago

This is now published as v3.1.0 on crates.io.