Update minimum serde version

hwchen / secret-service-rs

Rust library for interfacing with Secret Service API

Apache License 2.0

72 stars 28 forks source link

Update minimum serde version #68

Closed alex closed 1 year ago

alex commented 1 year ago

Without this, we cannot build with -Z minimal-versions

alex commented 1 year ago

Failure doesn't look related

complexspaces commented 1 year ago

I agree. I'm trying to determine what the best course of action is so that these changes can land. The options I see are:

Bumping MSRV to 1.64 to match zbus's upcoming one
Restrict the versions of toml_datetime to <= 0.6.1
Simply merge this with after doing a manual clippy check and figure out MSRV later.

I'm leaning towards the second option, at least until zbus makes a new release with their higher MSRV. Do you or your affected project have any preference?

alex commented 1 year ago

Adding something like https://github.com/sfackler/rust-openssl/pull/1808/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR79-R85 to the MSRV job is probably how I'd approach it.

complexspaces commented 1 year ago

Sorry for the delay. Do you mind rebasing this branch on master to pickup https://github.com/hwchen/secret-service-rs/pull/70? I believe that should fix the unrelated problems here. Thank you for the pointers as well.

alex commented 1 year ago

Done