hwclass / ziya

:pencil2: Your local in-browser editor
MIT License
62 stars 2 forks source link

Show notification after file save event #20

Closed altaywtf closed 7 years ago

altaywtf commented 8 years ago

We can build or use something like react-notification-system.

hwclass commented 7 years ago

Took it ;)

altaywtf commented 7 years ago

btw I've seen this widget yesterday. it has a cleaner UI than react-notification-system. maybe we can implement it.

hwclass commented 7 years ago

Maybe. I will look at it. What about the messages? After saving a file, is "Saved." enough or to add the full path or file name in that not. window better? Additionally, will we adding some error messages by this notification element?

altaywtf commented 7 years ago

Saved! is enough i think.

I think we can use that notifier to show error, info and success messages.

hwclass commented 7 years ago

And I think that react plugin needs some options to show an error, warning, information and some kind of messages. It can satisfy this need by customizing basic styles of the plugin notification window. Cool. I will also investigate and open an issue about it for that plugin..

hwclass commented 7 years ago

And here: https://github.com/pburtchaell/react-notification/issues/113