Configure dev build - Githubissues

hwclass / ziya

:pencil2: Your local in-browser editor

MIT License

62 stars 2 forks source link

Configure dev build #32

Closed altaywtf closed 7 years ago

altaywtf commented 7 years ago

Removed react-scripts dependency.
Uses express for both dev & production build.
Dev. server now has hot reloading capability.

Since we're not forced to use eslint config comes from react-scripts, I guess we need to agree on a new config for future usage. I'm a big fan of airbnb's eslint config and js styleguide so I suggest to use that one. What do you think @hwclass?

hwclass commented 7 years ago

Hi @altayaydemir. Thanks for your edits and yes, I am also a fan of airbnb's config for eslint which we can use. I am adding it as an issue into phase-2.

altaywtf commented 7 years ago

Hello again @hwclass!

For the sake of maintainability I've added eslint config in https://github.com/hwclass/ziya/pull/32/commits/047c9f62c0636add20062d80ac143282ae731a87 and changed some parts that causing eslint to throw warnings/errors.

I've also renamed src/src folder as src/client to prevent confusion.