hwclass / ziya

:pencil2: Your local in-browser editor
MIT License
62 stars 2 forks source link

embed codemirror fixes #5 #6

Closed hwclass closed 8 years ago

hwclass commented 8 years ago

Hi @altayaydemir

I have implemented by the first step and have some questions and need help about that integration like the following:

Note: You can select README.md or server.js for inspection the issues above.

Thanks

Barış

altaywtf commented 8 years ago

Good morning! I'll take a look at that today.

altaywtf commented 8 years ago

I've managed to fix styling (it was caused by css import here https://github.com/hwclass/ziya/pull/6/commits/31a3081a9d9f7985692ef4949d37aa969e2d7262#diff-3facc479f98ae2a8bcbe785cc437d7a1R6).

However, we're dont have any syntax highlighting yet :)

I guess we need to decide on file types by parsing them from names and tell Codemirror to use that language's styling.

screen shot 2016-11-01 at 13 25 51 2

hwclass commented 8 years ago

Hi @altayaydemir

Thank you very much about fixing this issue. Yes, you're right about deciding to get the file extension and support with codemirror's source coloring.I will open a task about it then at home, will be reviewing the code you have sent and merge if it is proper.

Regards

Barış