search

hwgilbert16 / scholarsome

Web-based interactive flashcard learning software
http://scholarsome.com
GNU Affero General Public License v3.0
516 stars 29 forks source link

Remove requirement for cards to have both term and definition filled in #153

Open ahmadshariq711 opened 6 months ago

ahmadshariq711 commented 6 months ago

When creating flashcards, and both term and definition is empty, the save button doesn't work. A red alert shows up, on the flashcard with the issue, but it would be better if the alert also shows up on top near the save button to increase user-friendliness.

image This is the empty flashcard before saving image This is after clicking the save button image It would be better to also have an alert message near the save button as the flashcard that is empty may not be visible

hwgilbert16 commented 6 months ago

I'll see if I can get the page to scroll to the first card with missing fields. If not, an alert up the top can be added.

ahmadshariq711 commented 6 months ago

Thank you!

BrianENguyen commented 6 months ago

If possible, it would be a lot better if you removed the requirement to have non-blank cards in a study set. It gets very tedious when saving a set, only to find out that there's a blank card. This would make me continuously scroll the page until I find it. Quizlet doesn't have non-blank cards requirement

hwgilbert16 commented 6 months ago

If possible, it would be a lot better if you removed the requirement to have non-blank cards in a study set. It gets very tedious when saving a set, only to find out that there's a blank card. This would make me continuously scroll the page until I find it. Quizlet doesn't have non-blank cards requirement

Good point. Initially, I was concerned about blank cards being a potential DOS attack vector. However, with the current ratelimiting that is in place, this is not a possibility.

This requirement will be removed in the next release.