search

hwittenborn / celeste

GUI file synchronization client that can sync with any cloud provider
GNU General Public License v3.0
1.13k stars 38 forks source link

Cannot Login with ProtonDrive when two password mode is enabled #180

Open MaoMaoCake opened 9 months ago

MaoMaoCake commented 9 months ago

Steps to recreate:

  1. Enable two password mode
  2. Try to login
hwittenborn commented 9 months ago

Hey @MaoMaoCake! Celeste doesn't currently support two password mode, as I was afraid it would cause confusion for users who weren't aware on what it is.

If this kind of functionality were to be shown in the UI, I'd probably want it behind some "advance config" toggle, but I haven't been able to think of a good way to do that yet.

How big of a blocker is this for you? I'm not super involved in the Proton ecosystem, does having 2FA enabled on your account not work enough over the two password stuff?

MaoMaoCake commented 9 months ago

hi, thanks for the response. proton's 2 password mode protects drive mail and calendar but does not protect vpn. I think the rational behind their choice is that you can have vpn access on devices that you don't want access to mail.

It's not much of an issue to me right not since I no longer have the need for it.

as for implementation maybe hide the toggle behind a gear icon on the login page?

hwittenborn commented 9 months ago

Cool, thanks for letting me know how that all works @MaoMaoCake! I still don't completely understand why most people would need it, but it definitely doesn't hurt to support it for the people that still want it turned on.

maybe hide the toggle behind a gear icon on the login page?

I think that'd be a really good idea, just having the button in the corner sounds like a really clean way of doing things. I'll try to give that a go sometime soon.

AngusIrwin commented 9 months ago

Two password mode is just another layer of security, but one that can be quite important.

For example the second password can be withheld from password manager, kept in one's head, so even if it was accessed by a third party (device stolen, data breach, etc.) the Proton account would still be inaccessible to a bad actor.

It's something I wouldn't be comfortable disabling, so support for it would be immensely helpful.

With regards to implementation, you could duplicate how 2FA uses an optional checkbox during login.

peroksid5 commented 6 months ago

Also interested in support for two-password mode, it is an essential feature in my opinion.

m0byn commented 3 months ago

I would like to add a vote to support 2 password mode. I always have it turned on for the reason @MaoMaoCake pointed out.

In terms of implementation: just implement it similarly to the 2FA method by showing a box to tick or not to tick. And for people who could be confused just put a question mark into or beside the field and explain that users who only use one password to login should not tick the box. Additionally, you could add a link to the help page by Proton for interested users.

As soon as the two password mode is implemented I am going to test this application right away! Previsouly, I tested the s3drive.app but it is super unstable and crashes all the time as soon as larger folders are synced. Hopefully, celeste will do a better job :smile: