search

hwittenborn / celeste

GUI file synchronization client that can sync with any cloud provider
GNU General Public License v3.0
1.16k stars 37 forks source link

Celeste is not verified by Google #30

Closed Hans03430 closed 1 year ago

Hans03430 commented 1 year ago

Hello, I've been trying this app to sync files with google drive and so far, everything is good when sychronizing regular files. (There's a case when dealing with google docs, where Celeste duplicates the Google file into a corresponding Microsoft equivalent). But that aside, I just wanted to let you know that Google says that Celeste hasn't been verified, when trying to log in to google drive from the application, which might raise some red flags for less technical users.

I am hopefully attaching an image of that message by Google. Thank you for this marvelous work, though!

imagen

hwittenborn commented 1 year ago

I hadn't gotten that warning before, I guess it was because I'm the developer for Celeste's Google integration or something like that. Celeste is in the process of being verified with Google though, I'm just waiting for them to accept it and then that warning should be gone.

I'll send a message once I can confirm that verification is complete, let's keep this issue open until then too.

aaylnx commented 1 year ago

Thank you very much for your work on this app! I'm glad this issue is being tracked. Just a heads up that I just tried logging in, and got a similar, but somewhat different message.

Instead of being told that the app is not verified, I was told the app is being blocked. Different issue?

celeste-blocked

ruemere commented 1 year ago

I'd like to say that I have experienced the same issue:

  1. Installed celeste using Ubuntu Software.
  2. Selected Google Drive server type, created "googleDrive" server.
  3. Received "This app is blocked..." message in Google Chrome.
  4. Subsequent startup of the application indicates that it is already running.
hwittenborn commented 1 year ago

Instead of being told that the app is not verified, I was told the app is being blocked. Different issue?

Yeah sounds like it, I'd say that's worthy of a separate issue. If you want go ahead and make another issue, I'm going to look into that regardless too though.

hwittenborn commented 1 year ago

Celeste straight-up being blocked is definitely an issue, I'm going to look into this straight when I get home in a few hours.

hwittenborn commented 1 year ago

I confirmed why you're getting the blocked error @aaylnx @ruemere: Celeste isn't yet verified, and is thus limited to having 100 users. Somehow that limit already got reached, and thus no more new users can use it.

I'm gonna see what I can do to get this done quicker on Google's end. I'll send another update once I have some more information.

hwittenborn commented 1 year ago

I'm going to go ahead and add a note in the README that Google Drive integration is currently not working because of the reasons I listed above. I sent an email out to Google to see if they can expedite the approval process, but I'm currently being limited at how busy they are and how quickly they can get to my request.

Again, I'll send a message here once I have another update.

ghost commented 1 year ago

Same issue for me, hopefully it gets approved, would be cool to use my drive with this and cryptomator

ruemere commented 1 year ago

No worries. Keep up the good work!

On Fri, Feb 10, 2023, 03:33 Jacob Gonzales @.***> wrote:

Same issue for me, hopefully it gets approved, would be cool to use my drive with this and cryptomator

— Reply to this email directly, view it on GitHub https://github.com/hwittenborn/celeste/issues/30#issuecomment-1425093157, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACK5YRMESZK5N6TXVSC2LXLWWWSGFANCNFSM6AAAAAAUUVUV6E . You are receiving this because you were mentioned.Message ID: @.***>

budhajeewa commented 1 year ago

@hwittenborn rclone allows using our own client_id with Google Drive (See: https://rclone.org/drive/#making-your-own-client-id). Providing an interface within Celeste to that functionality of rclone would do two things:

  1. Allow you to bypass the problem described in this GitHub Issue.
  2. Improve confidence in users.
hwittenborn commented 1 year ago

@budhajeewa: I've thought about allowing a custom client ID, but the extra complexity in the UI didn't seem worth it. I know it solves this issue until it gets resolved, but the Celeste OAuth provider should just work, and I'd prefer to avoid adding a hacky workaround like this just for the sake of fixing a temporary issue.

In the meantime, you could also just run rclone authorize drive with the custom client ID and secret, and then if you throw it into Celeste's rclone config it should just work.

In what ways does it improve confidence though?

budhajeewa commented 1 year ago

@hwittenborn Even without this particular issue, allowing people to use their own client_id if they so desire will give confidence to people who do not use it as well because they know that if they wish, there is a way to connect to Google Drive through their own client_id. Only power users would use this, and you can instruct them to first configure rclone on their own, and then copy the config to Celeste, just like you did here. So you'd only have to add a tip in the UI.

Can you please tell me how to add the configuration from my ~/.config/rclone/rclone.conf to that of Celeste, so that I can give it Celeste a try?

I copied it to ~/.var/app/com.hunterwittenborn.Celeste/config/rclone/ directory, but Celeste doesn't seem to recognize it.

aaylnx commented 1 year ago

@hwittenborn I agree with your thoughts here. Avoiding the complexity of that is a good idea. I don't mind waiting until this issue can be sorted out.

hwittenborn commented 1 year ago

Only power users would use this, and you can instruct them to first configure rclone on their own, and then copy the config to Celeste, just like you did here. So you'd only have to add a tip in the UI.

If it does get added to the UI it'd probably just be a toggle to where you can show advanced options, and then things like the Client ID/Secret would be under there.

Can you please tell me how to add the configuration from my ~/.config/rclone/rclone.conf to that of Celeste, so that I can give it Celeste a try?

I copied it to ~/.var/app/com.hunterwittenborn.Celeste/config/rclone/ directory, but Celeste doesn't seem to recognize it.

Do you have the remotes named the same way in both configs? Celeste stores the names of the rclone remotes in a separate database file and won't recognize it if you add them under different names. If they're named the same Celeste shouldn't have any issue using them though.

budhajeewa commented 1 year ago

@hwittenborn

Only power users would use this, and you can instruct them to first configure rclone on their own, and then copy the config to Celeste, just like you did here. So you'd only have to add a tip in the UI.

If it does get added to the UI it'd probably just be a toggle to where you can show advanced options, and then things like the Client ID/Secret would be under there.

That would be perfect :+1:!

Can you please tell me how to add the configuration from my ~/.config/rclone/rclone.conf to that of Celeste, so that I can give it Celeste a try? I copied it to ~/.var/app/com.hunterwittenborn.Celeste/config/rclone/ directory, but Celeste doesn't seem to recognize it.

Do you have the remotes named the same way in both configs? Celeste stores the names of the rclone remotes in a separate database file and won't recognize it if you add them under different names. If they're named the same Celeste shouldn't have any issue using them though.

I couldn't set-up Celeste to begin with, as I was hit with the Google error.

So I opened ~/.var/app/com.hunterwittenborn.Celeste/config/celeste/celeste.db SQLite DB and added "GoogleDrive" (Name of my Google Drive remote.) to the remotes table. Now Celeste's main UI opens correctly, and my remote is displayed in the sidebar.

However, when I try to add a directory to be sync'ed, I get the error "Failed to check if the specified remote directory exists: didn't find section in config file.". I can confirm that ~/.var/app/com.hunterwittenborn.Celeste/config/rclone/rclone.conf contains the following:

[GoogleDrive]
type = drive
client_id = <client_id>
client_secret = <client_secret>
token = <token>
team_drive =

Any other change I'd have to do to get Celeste running?

hwittenborn commented 1 year ago

However, when I try to add a directory to be sync'ed, I get the error "Failed to check if the specified remote directory exists: didn't find section in config file.". I can confirm that ~/.var/app/com.hunterwittenborn.Celeste/config/rclone/rclone.conf contains the following:

You need to place the file at ~/.var/app/com.hunterwittenborn.Celeste/config/celeste/rclone.conf instead (it should be celeste/rclone.conf at the end instead of rclone/rclone.conf).

hwittenborn commented 1 year ago

In regards to the general status of this issue too - it looks like progress is being made on getting Celeste verified. I'm just getting some final things going so Celeste applies with Google's usage policies and it should be good to go.

I'm hoping to have Google Drive integration working within a week, if not less. I can't guarantee much yet, but it's looking like it's at least going in that direction.

ghost commented 1 year ago

In regards to the general status of this issue too - it looks like progress is being made on getting Celeste verified. I'm just getting some final things going so Celeste applies with Google's usage policies and it should be good to go.

I'm hoping to have Google Drive integration working within a week, if not less. I can't guarantee much yet, but it's looking like it's at least going in that direction.

thanks for the update!

ghost commented 1 year ago

In regards to the general status of this issue too - it looks like progress is being made on getting Celeste verified. I'm just getting some final things going so Celeste applies with Google's usage policies and it should be good to go.

I'm hoping to have Google Drive integration working within a week, if not less. I can't guarantee much yet, but it's looking like it's at least going in that direction.

any new updates?

hwittenborn commented 1 year ago

any new updates?

I actually just got an email earlier today - it said they're still reviewing my app, but it's the first time they haven't asked for any changes (after 4-5 times of changes needing to be made), so it definitely looks like progress is being made.

I just got this one about a week after the last though, so I'm not positive on what the speed is though. I'm hoping they just have to test the functionality and then I'm good to go though. I'll keep y'all posted on any further messages I get

hwittenborn commented 1 year ago

I just got another email back from Google - they're wanting some branding changes in Celeste (just some buttons that are shown here). I can't just throw that button into Celeste itself though (it would look out of place quite badly), so when the browser opens up for authentication I'm just gonna throw up the button on there.

I've got a bug fix I have to finalize, and then I'm gonna get that done and send an email back to Google letting them know about the change.

ruemere commented 1 year ago

No worries, mate. Just do it at your own pace. And if you think that branding is an issue at Google, let me tell you that Apple is in some cases three times as obstinate.

On Thu, 23 Feb 2023 at 02:19, Hunter Wittenborn @.***> wrote:

I just got another email back from Google - they're wanting some branding changes in Celeste (just some buttons that are shown here https://developers.google.com/identity/branding-guidelines). I can't just throw that button into Celeste itself though (it would look out of place quite badly), so when the browser opens up for authentication I'm just gonna throw up the button on there.

I've got a bug fix I have to finalize, and then I'm gonna get that done and send an email back to Google letting them know about the change.

— Reply to this email directly, view it on GitHub https://github.com/hwittenborn/celeste/issues/30#issuecomment-1441103161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACK5YRMCQ3UE7276QJGOMXDWY23IDANCNFSM6AAAAAAUUVUV6E . You are receiving this because you were mentioned.Message ID: @.***>

-- @.***

hwittenborn commented 1 year ago

Alright, I've made the changes that Google requested from me (they're going to be published shortly as soon as I get a tiny bug that got introduced with it fixed), and I've sent an email back to them letting them know about it. Now it's just me waiting for a response, I'll send another message once I get something.

hwittenborn commented 1 year ago

Just got an email back from Google, Celeste is now verified 🥳! Can one of y'all confirm if Google Drive integration is working fine now?

bernimoses commented 1 year ago

Hmm, didn't get the not verified but after giving access to Celeste this happens: image

edit: maybe it's some google issue, since i can't see Celeste in my "Third-party apps with account access".

hwittenborn commented 1 year ago

@bernimoses: Thanks for the heads up. I'll be at my computer in an hour or two, I'll get that looked at then.

nboughton commented 1 year ago

I'm running Celeste from the flatpak and it seems to connect to google drive, I can authorise the app and the rclone config gets setup but no data appears to be syncing. I had a look at the flatpak permissions in flatseal and I'm not sure this is a good setup:

image

I would assume that Celeste should have r/w access to my home dir but all system data seems excessive.

EDIT: Nevermind, I didn't think I needed to/could add a sync folder as the button was grayed out. Added my local folder and remote folder config and everything seems to be working.

hwittenborn commented 1 year ago

I would assume that Celeste should have r/w access to my home dir but all system data seems excessive.

It's in case you want to sync anything outside of it - I wanted Celeste to be best for less experienced users, and those users might still want to sync outside of their home directory, but might not know how to set up Flatpak permissions properly. What do you think?

edit: maybe it's some google issue, since i can't see Celeste in my "Third-party apps with account access".

I just did some testing and it all appeared to work fine on my end - are you using the Flatpak version? It still needs to be updated - it'll be available on Flathub in about three hours after the beta period that Flathub requires finished.

hwittenborn commented 1 year ago

EDIT: Nevermind, I didn't think I needed to/could add a sync folder as the button was grayed out. Added my local folder and remote folder config and everything seems to be working.

Is it still greyed out? It sounds like some kind of a UI issue if it's behaving like that.

nboughton commented 1 year ago

EDIT: Nevermind, I didn't think I needed to/could add a sync folder as the button was grayed out. Added my local folder and remote folder config and everything seems to be working.

Is it still greyed out? It sounds like some kind of a UI issue if it's behaving like that.

Yup, still grayed out but the sync seems to be working fine.

supermarioprof commented 1 year ago

Celeste seems to work for me with Google Drive syncing!

nboughton commented 1 year ago

Here's a screenshot of the app window: image

supermarioprof commented 1 year ago

...but crashing after a while, while working, and using lots of system resources (Manjaro here)

nboughton commented 1 year ago

No crashes or high resource use for me so far. I'm running on Fedora Silverblue 37.

hwittenborn commented 1 year ago

...but crashing after a while, while working, and using lots of system resources (Manjaro here)

Could you send over the crash log that gets shown? You could email/DM me it if it would be preferred by you.

hwittenborn commented 1 year ago

@nboughton: I'm suspecting that might be an issue with your icon theme somehow - could you send over what theme you're using?

nboughton commented 1 year ago

@nboughton: I'm suspecting that might be an issue with your icon theme somehow - could you send over what theme you're using?

Papirus

supermarioprof commented 1 year ago

ok, maybe my fault but I report here

immagine

I deleted a folder locally while syncing

nboughton commented 1 year ago

Had a crash: image

bernimoses commented 1 year ago

edit: maybe it's some google issue, since i can't see Celeste in my "Third-party apps with account access".

I just did some testing and it all appeared to work fine on my end - are you using the Flatpak version? It still needs to be updated - it'll be available on Flathub in about three hours after the beta period that Flathub requires finished.

Oh sorry my bad. Yeah i'm using the flatpak version.

hwittenborn commented 1 year ago

This issue's starting to get cluttered up with other issues, so I'm going to go ahead and put all this stuff into other issues. Feel free to make your own issue if I accidentally looked over something.

@supermarioprof @nboughton: Could y'all open up issues for your stuff? I'm gonna need some more info, but it'll keep the issues cleaner if y'all start them off.

hwittenborn commented 1 year ago

I'm gonna go ahead and get this closed since the fix for this issue itself is now implemented - if y'all still experience issues with other stuff (e.g. crashes), feel free to open new issues.