search

hwittenborn / celeste

GUI file synchronization client that can sync with any cloud provider
GNU General Public License v3.0
1.23k stars 41 forks source link

Add Proton Drive support #31

Closed noverby closed 1 year ago

Samillion commented 1 year ago

:O I didn't even know this was possible, Nice!

noverby commented 1 year ago

@Samillion Nevermind it is not: https://github.com/rclone/rclone/issues/6072

hwittenborn commented 1 year ago

Yeah what @noverby said. It's definitely something I want to add if I could, just the fact that Proton Drive doesn't have a public API makes that basically unmanageable. If they support such in the future I'll definitely get it added though.

ayykamp commented 1 year ago

Take a look at rclone/rclone#6072 again :)

noverby commented 1 year ago

@ayykamp Nice!

noverby commented 1 year ago

@hwittenborn so are you still interested in adding Proton Drive support? :)

hwittenborn commented 1 year ago

That's great to see @ayykamp! I'm definitely interested in getting this going then @noverby, I'll always be open with adding anything that's supported by rclone (except for some remotes like Google Photos that don't make a ton of sense for file syncing).

I'm currently working on a few major issues with Celeste, so I can't give an ETA when it'll be completed. This is definitely on my radar considering the popularity of Proton's services though!

RayJW commented 1 year ago

Just in case, this flew under the radar. Rclone 1.64 added support for Proton Drive! :)

hwittenborn commented 1 year ago

Thanks for the update @RayJW! I hadn't mentioned it, but I was waiting for Proton Drive to get into a stable rclone release before doing much with it. Now that it's all there I shouldn't have any issues getting it added into Celeste though.

I'm working on a few issues with other backends at the moment (notably Dropbox and Google Drive), but I'll get this looked at after I get those figured out.

hwittenborn commented 1 year ago

Proton Drive should now be available in v0.6.0.

I'd like to note that if you're using a two-step password that you won't be able to log in currently. It wouldn't have been much extra work to add support for the second password to the UI, but I was thinking it'd create confusion for new users who don't know what that is, and I ultimately decided on excluding it.

If there's any demand for it I'm more than glad to look back into implementing it though, just let me know if that's the case for any of y'all.