hwkiem / imho

davdiv.vercel.app
3 stars 1 forks source link

miped - Prettier, ESLint and github actions #84

Closed miped closed 3 years ago

miped commented 3 years ago

Adds a couple of things:

Also fixes a bunch of eslint errors, and marks a couple of them as ignored for now until we can fix them for real.

This is run on every PR as you see on this one, but also every commit to main. Makes it a lot easier to keep things "clean" and make sure you don't check in anything that breaks it all ;). Eventually we'll tie some deployment procedures into this.

hwkiem commented 3 years ago

Oh this is cool

hwkiem commented 3 years ago

@miped Also I have blocked remote pushes to main for the repo and we've been squashing PRs into single commits to main. Does this seem like a reasonable way to go about things?

miped commented 3 years ago

@miped Also I have blocked remote pushes to main for the repo and we've been squashing PRs into single commits to main. Does this seem like a reasonable way to go about things?

I tend to prefer not squashing. It has a tendency to create more conflicts than necessary. I'd probably recommend just doing merge commits unless it becomes an issue.