search

hwm2746 / brain-mesh-builder

Construct surface mesh models based on 3D image stacks of brains
GNU General Public License v3.0
3 stars 1 forks source link

Source dist for package managers #4

Closed outpaddling closed 1 year ago

outpaddling commented 1 year ago

Hi again... It would be good if you could create a standard minimal source dist tag/release, with no object files, executables, or test output (unless it's needed for comparison), etc. As of now I have a hack in the FreeBSD port and pkgsrc package to remove the Ubuntu binaries after extracting the dist and I'm not sure of the test output is useful, while it makes the dist tarball rather big. Minor FYI, prefixing the release version with "v." or anything else is a minor nuisance for package managers. A standard Github tag/release with a version of just x.y.z works with the defaults. Thanks...

acchangg12 commented 1 year ago

I made a new tag (1.1) without test folder and object files. Since github doesn't like empty folders, the ./bin/ and ./obj/ folders are gone, so a user would have to manually add these in to build.

outpaddling commented 1 year ago

That's great, thanks. FYI, when you added the Makefile patches, the TABs got converted to spaces and things got out of alignment. I'm attaching a fixed Makefile that also creates the bin and obj dirs automatically. Makefile.gz

BTW, there's no rush to put out new releases on my account. The FreeBSD ports and pkgsrc frameworks can work with a commit hash until everything is fully tested and you're ready for another release.

acchangg12 commented 1 year ago

Thanks for catching that and for the updated Makefile - I went ahead and made the bug fix and updated Makefile.

Great - glad to hear everything is working.