search

hwms / pidgin-privacy-please

Automatically exported from code.google.com/p/pidgin-privacy-please
GNU General Public License v3.0
0 stars 0 forks source link

Compare accounts with regular expression. #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When comparing the account if is in blocklist, we can use regular
expression to decrease the number of blocklist.

There is a patch in the attachment.

We can add users to the blocklist such as "/gxd305/" to block all the users
who's account include 'gxd305'.

Original issue reported on code.google.com by gxd...@gmail.com on 15 Nov 2008 at 7:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Good idea, the patch looks promising. I'll have a closer look at it in the next 
few
days and push a new release if everything is okay.

Original comment by o...@desire.ch on 17 Nov 2008 at 5:45

GoogleCodeExporter commented 9 years ago

Original comment by o...@desire.ch on 17 Nov 2008 at 5:49

GoogleCodeExporter commented 9 years ago 
Okay, those were more "few days" than I had expected. Anyway.

First of all, thanks for the patch.

Then: I'm wondering, why are you not using g_regex
(http://library.gnome.org/devel/glib/unstable/glib-Perl-compatible-regular-expre
ssions.html)?
That one is already included in glib, so we don't get an additional dependency. 
Also,
your patch only affects authorization requests, not messages, which is probably
confusing for the user.

It would be nice if you could adjust your patch (and while you're at it, maybe 
reduce
the amount of code duplication), otherwise I'll look into it when I find some 
time.

Original comment by o...@desire.ch on 16 Mar 2009 at 3:45

GoogleCodeExporter commented 9 years ago

Original comment by o...@desire.ch on 25 Aug 2009 at 2:38

GoogleCodeExporter commented 9 years ago

Original comment by o...@desire.ch on 22 Oct 2009 at 2:48

GoogleCodeExporter commented 9 years ago 
This has been added to SVN trunk and will be shipped with the next release. 
Thank you for your patience.

Original comment by o...@desire.ch on 8 Jul 2010 at 3:05

GoogleCodeExporter commented 9 years ago

Original comment by o...@desire.ch on 9 Jul 2010 at 3:50