search

hwoodward / Remote-Card-Games

Program for playing card games online/remotely. Goal is to play a game of hand and foot with multiple groups in different locations.
MIT License
2 stars 1 forks source link

Organize gui code #107

Closed slwoodward closed 4 years ago

slwoodward commented 4 years ago

created Helper functions for HandView. Those that are HandAndFoot specific all deal with buttons, and can be found in HandAndFootButtons.py. Those that deal with displaying cards are not HandAndFoot specific, and can be found in HandManagement.py. Also incorporated feedback from 4/4/2020 game. Verified that pyinstaller can make executable, and that it runs.

hwoodward commented 4 years ago

Looked at what was done so far - and the changes to HandAndFootButtons all look great. The changes I saw in HandManagement were also good, but there are some left to do (mostly with the comment unresolved). Only thing I know of that I'm not sure you have an unresolved comment for still is the CapitalCase methods in HandManagement (like in HandAndFootButtons to match style guide).

slwoodward commented 4 years ago

Discovered an issue in some work on RescaleCards and RefreshXY. Hold off re-review until I let you know they're resolved. UPDATE: I have resolved the issue. Still passing hand_view to various methods in HandManagement where only a few variables from hand_view are needed. However, a lot of this code be unnecessary or rewritten once I introduce card.deck to definition of card. Therefore, I'd like to put off making those edits. Most conversations are resolved. If you're OK with this branch, please OK merge.