search

hwoodward / Remote-Card-Games

Program for playing card games online/remotely. Goal is to play a game of hand and foot with multiple groups in different locations.
MIT License
2 stars 1 forks source link

Hand view #38

Closed slwoodward closed 4 years ago

slwoodward commented 5 years ago

Progress made on handview. Feedback always appreciated.

slwoodward commented 5 years ago

I will go through and address all your comments tomorrow. I plan to remove # comments that are really just notes for myself, and clean-up other comments. I think ClickableImage to ClickImg.

slwoodward commented 5 years ago

Working on your other comments, but this one I'll leave for you :)

On Wed, Sep 25, 2019 at 8:09 PM Helen notifications@github.com wrote:

@hwoodward commented on this pull request.

In source/server/GameServer.py https://github.com/hwoodward/Remote-Card-Games/pull/38#discussion_r328418602 :

@@ -60,7 +60,13 @@ def Send_publicInfo(self):

 def Send_discardInfo(self):
     """Send the update to the discard pile"""

  • <<<<<<< HEAD

  • SLW asks which version to keep?? comment out next two lines and keep two below....

  • info = self.DiscardInfo()

  • self.SendToAll({"action": "discardInfo", "top_card": info[0].Serialize(), "size": info[1]})

  • =======

     info = self.discard_info()

Keep this one here on the bottom - its up to date after the style reformation. I can't edit in this window but you can leave this in place for me to fix in my next MR and/or open a bug case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hwoodward/Remote-Card-Games/pull/38?email_source=notifications&email_token=AFBGQF7XADITSHFPWPR2UMDQLQRVDA5CNFSM4IXYW2V2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCF66LJA#pullrequestreview-293463460, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBGQFZZV2WF32BI23UYS23QLQRVDANCNFSM4IXYW2VQ .

slwoodward commented 5 years ago

Requested changes made.