search

hwoodward / Remote-Card-Games

Program for playing card games online/remotely. Goal is to play a game of hand and foot with multiple groups in different locations.
MIT License
2 stars 1 forks source link

Server crashes when one player disconnects #97

Closed hwoodward closed 4 years ago

hwoodward commented 4 years ago

Describe the bug When one player (possibly the active player) disconnects, the server crashes.

Mostly seen when running with remote server, not yet reproduced locally.

hwoodward commented 4 years ago

Suspect - but have yet to confirm - that we are actually seeing the server crash when a player tries to connect during an active game, is denied, goes through disconnect code, and then we crash. The remote server has non=game pings happening on its ports at various times and thus may be more susceptible to this.

hwoodward commented 4 years ago

Confirmed that a player connecting during an active game crashed the server due to the disconnect code. Also confirmed that pinging the server port with a web browser had the same result. Both fixed in linked MR

slwoodward commented 4 years ago

Fixed and tested with group on March 28.