search

hwookim / storybook-addon-cookie

Set document.cookie for each Storybook.
MIT License
9 stars 3 forks source link

Storybook 8 compatibility #10

Open joevaugh4n opened 6 months ago

joevaugh4n commented 6 months ago

Hey @hwookim ! I’m reaching out from the core SB team :)

Storybook 8 (our next major release) is coming soon, and it introduces some breaking changes that your addon might need to account for.

We’ve listed all the key changes in a new Storybook 8 migration guide, and we’d encourage you to check it out and see if your addon is impacted.

We also have an addons channel in our Discord community, which we’d like to use to better communicate with addon authors in the future. If you’re not part of the server, consider joining here and message me (@joevaugh4n) so that I can give you the addon creator role! If you’re already in the server, please just ping me and I’ll respond to you there.

Thanks for being a part of our addon community!

Joe

sandwichsudo commented 5 months ago

Hiya, I've just tried upgrading to Storybook 8 and have found my cookies are no longer set once I upgraded my Storybook to version 8 when using this add-on. I'll try and investigate a bit more what the breaking change might be and add notes here.

First off, this message comes out when I start my Storybook with version 8 installed:

WARN The following packages are incompatible with Storybook 8.0.0 as they depend on different major versions of Storybook packages: WARN - storybook-addon-cookie@3.2.0

sandwichsudo commented 5 months ago

I had a go at upgrading:

and then the demo Storybook up to v8.0 and seemed to work well

Screenshot 2024-03-14 at 17 05 29

Happy to push a PR if that's any help

paul-asvb commented 3 months ago

i threw this together. https://github.com/hwookim/storybook-addon-cookie/pull/11

hwookim commented 3 months ago

I apologize for the delay in handling this issue. I'll do my best to get it taken care of this week.

fernandopasik commented 2 weeks ago

Thank you for the update! Is there anything in particular why the alpha release for 4.0 and not a full one?

hwookim commented 2 weeks ago

@fernandopasik There are a few issues we haven't resolved yet. #12 T.T There is an issue with the parameter not being called properly on initial load and therefore not being properly exposed in the toolpane, which i'm still trying to resolve.

I'll try to resolve them as soon as possible!