search

hwsmm / cosutrainer

A simple osu! map rate changer
GNU General Public License v3.0
26 stars 1 forks source link

Use the most common bpm when speeding up a map using bpm instead of a multiplier #6

Open tkilele opened 6 days ago

tkilele commented 6 days ago

Instead of using the highest bpm use the one that lasts the majority of the map. Would also be nice to have the bpm in the difficulty name but thats preference.

Everything else is great! :+1:

hwsmm commented 15 hours ago

I'll add BPM in difficulty name! I didn't do this because we already have BPM in song select, and I wanted to give some distinction between osu-trainer and mine, but I agree that this was a step backward :sweat_smile:

As for using the most common bpm, implementing it isn't hard, but it adds a bit of complexity as the program needs to read a map file to the end to calculate drain time and store all timing points to calculate it accurately (It currently reads all timing points, uses the highest one, and skips reading hit objects). Using the maximum bpm is still consistent for most cases in my opinion.

Tell me if this is a deal-breaker for you! I'm fine with implementing this, but there were some reasons why I didn't use the most common bpm.

tkilele commented 14 hours ago

Definitely not a deal-breaker just what I prefer, but if you think the way it works right now is better then its all good!