search

hxf31891 / react-gradient-color-picker

An easy to use color/gradient picker for React.js
MIT License
146 stars 48 forks source link

why eyedropper does not support Firefox #31

Closed rishonide-swivel closed 2 years ago

rishonide-swivel commented 2 years ago

Screenshot from 2022-10-28 08-32-51

hxf31891 commented 2 years ago

Please give me some more information, what is the behavior exactly? What version are you using?

rishonide-swivel commented 2 years ago

Please give me some more information, what is the behavior exactly? What version are you using?

seems it doesn't support on firefox browser. color doesn't pick in firefox browser

hxf31891 commented 2 years ago

What version of the color picker are you using?

rishonide-swivel commented 2 years ago

What version of the color picker are you using? "react-best-gradient-color-picker": "2.1.5", this works fine in chrome

hxf31891 commented 2 years ago

The eye dropper works differently on different browsers. By far the best functionality is provided by the recently released EyeDropper API. Unfortunately, it still has very limited browser compatibility (Chrome, Opera & Edge). I implemented a custom Eye Dropper for all non compatible browsers. To my knowledge, that functionality is working as expected, although the component does look quite different.

I'm testing on Firefox now and getting desired behavior. (see attached video). I will confess however that I rarely use Firefox. If your experiencing some other bugs give me a detailed breakdown and I'll try and get it fixed up ASAP.

https://user-images.githubusercontent.com/49292623/198558648-f35e94b4-5a7b-4d22-80b9-6e547b1be246.mov

rishonide-swivel commented 2 years ago

The eye dropper works differently on different browsers. By far the best functionality is provided by the recently released EyeDropper API. Unfortunately, it still has very limited browser compatibility (Chrome, Opera & Edge). I implemented a custom Eye Dropper for all non compatible browsers. To my knowledge, that functionality is working as expected, although the component does look quite different.

could you let me know the version of firefox?

hxf31891 commented 2 years ago

Firefox 106.0.2 on Mac Silicon

hxf31891 commented 2 years ago

Closing with assumption package is functioning normally