search

hxf31891 / react-gradient-color-picker

An easy to use color/gradient picker for React.js
MIT License
144 stars 45 forks source link

Option to disable dark mode #77

Closed Rafi993 closed 2 months ago

Rafi993 commented 8 months ago

It should be possible to disable dark mode if needed (for apps that don't support dark mode)

hxf31891 commented 8 months ago

@Rafi993 should be relatively easy to add. Will include in next update.

hxf31891 commented 8 months ago

@Rafi993 not included in documentation yet but v3.0.5 adds disableDarkMode (bool) prop to picker.

TurekBot commented 7 months ago

Thanks for putting this together. I gave it a try today, but it doesn't seem to work. A quick search is showing only a single instance of disableDarkMode in the codebase, so maybe something went awry? 🤷

TurekBot commented 6 months ago

@hxf31891, am I reading this right, that the disableDarkMode prop was broken in commit 99ad3eb8b0df326ddf4e4ea80a57bd96e850dfc2?

PierreAtUptale commented 6 months ago

This is also preventing me to upgrade to v3, tried experimenting with Material-UI makeStyles overrides to no avail.

PierreAtUptale commented 6 months ago

Made a draft PR that I haven't had time to test, hoping to do it by the end of the week.

Edit: Done, PR is ready for review.

hxf31891 commented 2 months ago

@PierreAtUptale @TurekBot @Rafi993 this should be back as of 3.0.10