search

hxf31891 / react-gradient-color-picker

An easy to use color/gradient picker for React.js
MIT License
146 stars 49 forks source link

Restore behavior of disableDarkMode after commit 99ad3eb regression #91

Closed PierreAtUptale closed 4 months ago

PierreAtUptale commented 8 months ago

This change restores the functionality of disableDarkMode prop, whose role is to prevent the automatic use of the dark mode stylesheet if the browser has the prefers-color-scheme media value set to dark. This was initially introduced to better integrate in application that do not have a dark mode, but this feature got broken in a subsequent change.

See #77.

There may be a better way of merging styles than using my of combineMultipleCssModules utility, if anyone has any in mind.

hxf31891 commented 7 months ago

I will take a peak at this ASAP and try and get that fixed for you. Theres has been a lot of complications bundling the styles for Next and thats limited my ability to interact with darkMode and make it accessible.

hxf31891 commented 4 months ago

this should be fixed as of 3.0.10

n3nikita commented 3 months ago

Looks like it's not fixed. I'm on 3.0.10 and it doesn't seem to work.