search

hxlniada / webpack-concat-plugin

a plugin to help webpack to concat file and inject to html
https://github.com/hxlniada/webpack-concat-plugin
97 stars 55 forks source link

updates for new hooks in html-webpack-plugin #71

Open Jorybraun opened 5 years ago

Jorybraun commented 5 years ago

I ran into this issue today after upgrading to the next version of weback-html-plugin.

61

i left the old compiler options, this should be backwards compatible as i ran it with both versions of htmlWebpackPlugin, only the local decency version of webpack has to be the latest for this to work i guess, if that is true then the backwards compatibility will most likely not work.

Im not really sure if this will actually work unless the local version of html-webpack-plugin is upgraded aslo.

Perhaps we a conditional for the old compilation hooks. that might work.

Let me know what you think, this is my first time contributing to an open source project! :)

Jorybraun commented 5 years ago

@hxlniada, hey i'd to help resolve any issues you have with this PR really need it.

deshiknaves commented 4 years ago

Is this project still maintained? Otherwise, would you like some new contributors so that they can maintain this? I really don't want to have to fork this.

Jorybraun commented 4 years ago

@deshiknaves,

Id be happy to maintain this but i think a new package will have to be created

deshiknaves commented 4 years ago

@jaketodaro yep, me too. @hxlniada any thoughts?

aesyondu commented 4 years ago

If this project is abandoned, I found another project which worked well for my use case: https://github.com/markshapiro/webpack-merge-and-include-globally

In my case I wanted it to output a manifest file using https://github.com/ztoben/assets-webpack-plugin. webpack-concat-plugin wouldn't play nice with assets-webpack-plugin as it didn't map the name to the manifest (only an empty string ""). Lucky for me webpack-merge-and-include-globally worked.

redfox05 commented 3 years ago

I tried webpack-merge-and-include-globally and it works great for JS. Would just really like a simple solution of concat and sourcemaps for CSS. If anyone has suggestions, im all ears.

tibineagu commented 3 years ago

Can confirm webpack-merge-and-include-globally works more or less as a drop-in replacement for this plugin - and will likely be fine for most devs' needs.

Sad that the maintainer completely abandoned this library, it would have been quite elegant for them to pass ownership to the community and the plugin would have been kept alive.