Add nodes for OpenDoorsWindows and UserDefinedStates

hxmelab / node-red-contrib-bosch-shc

Bosch Smart Home Controller (SHC) nodes for Node-Red

https://flows.nodered.org/node/node-red-contrib-bosch-shc

MIT License

20 stars 6 forks source link

Add nodes for OpenDoorsWindows and UserDefinedStates #77

Closed saemmy closed 2 months ago

saemmy commented 2 months ago

Add 2 new nodes

Get OpenDoorsWindows
Get/Set UserDefinedStates

saemmy commented 2 months ago

Hi @hxmelab , I tested this locally, works fine, but there is one point: when setting a UserDefinedState, I get two responses: the first one is the longpolling-event containing the old value and the second one is the msg.payload with the correct new value. Is there any possibility to suppress the first message with the old value?

hxmelab commented 2 months ago

Hi Saemmy, thanks for you contribution. To answer your question, I need some more context. What's the goal of the new nodes you provide? Why does the current nodes does not fulfill your needs, etc.

saemmy commented 2 months ago

OpenDoorsWindows node is fine. Wth the UserDefinedState node, you can reproduce it the following way:

create a new UserDefined state in your Bosch SmartHomeSystem (Automations/Szenario tab)
Add node and select the before created state
put in the node
you will receive one event with status that´s from the longpolling
you will receive a second message with status I would like to suppress the first longpolling event.

saemmy commented 2 months ago

May be I got it. It´s because when I´d like to set a state I do a PUT and a GET afterwards. If I just do a PUT, there is only one message. I will commit a fix...