search

hyakumori / crm

Hyakumori Forest CRM
GNU General Public License v3.0
0 stars 0 forks source link

broken imports in data_import #30

Closed iosefa closed 3 years ago

iosefa commented 3 years ago

On https://github.com/hyakumori/crm/blob/next/data_import/services/customer.py#L7 there is an import to a file that does not exist. It was removed in 9c8f7d6b467621123eb945d830a4f28d20989a2c.

However, this is for the data_import program and I suspect that this is not used and that there are probably other potential problems.

iosefa commented 3 years ago

I do not fully understand the data_import program. In my opinion it should be removed and put into a separate repository. It seems like this might be used to import the original data that is in an Excel spreadsheet into the CRM. i.e. if you start with an empty database it is used to initialize the database and import the crm data. But it is lacking sufficient documentation.

iosefa commented 3 years ago

Another issue - although this is not in data_imports/ is that there seem to be broken import references to slack and graphql. Neither are listed in requirements.txt nor are installed. In fact - Im not sure what slack is ... Here are results of pycharm code inspection:

Screen Shot 2021-01-28 at 16 32 20
iosefa commented 3 years ago

As per conversation with Tabata San, datafluct will no longer make code changes and so this is likely to not be resolved. Given that this features (data_import) has not been updated for some time, is broken, and requires too many dependencies, I will remove it.

dkastl commented 3 years ago

Let's remove it if we don't see for what it should be used. As discussed the data import maybe has been changed to CSV import from the application.