search

hyakumori / crm

Hyakumori Forest CRM
GNU General Public License v3.0
0 stars 0 forks source link

pass all urls as env vars #54

Closed iosefa closed 3 years ago

iosefa commented 3 years ago

Any dependent service (like the rest API, graphql API, or geoserver) should be referenced by loading an env variable. This is done here for example: https://github.com/hyakumori/crm/blob/83939f0aced3c5493d6bef17784f46d0cb6d0655/src/plugins/vue-apollo.js#L16

It seems to be that the only changes that should be introduced are to add the same for geoserver and add a geoserver env variable, for example:

VUE_APP_GEOSERVER=http://localhost:8000/geoserver

Reading https://cli.vuejs.org/config/#devserver-proxy, I also take it that https://github.com/hyakumori/crm/blob/83939f0aced3c5493d6bef17784f46d0cb6d0655/vue.config.js#L8 should also be changed to read from an env variable:

VUE_APP_BACKEND=http://localhost:8000

maybe?

iosefa commented 3 years ago

see https://cli.vuejs.org/config/#devserver-proxy regarding devserver-proxy